Skip to content

Conversation

@Bananeweizen
Copy link
Contributor

No description provided.

@jukzi
Copy link
Contributor

jukzi commented Nov 4, 2024

@jannisCode please review

@jannisCode
Copy link
Contributor

jannisCode commented Nov 5, 2024

@Bananeweizen I created the N&N’s following the guidelines on this Eclipse instructions page, which encourages us to "generate some excitement" in the text. That’s why I used enthusiastic language. However, I noticed that the changes you made to the first two sections are more factual and less engaging.

Since I’m new to Eclipse, I wanted to check if I may have misunderstood the guidelines. If understood them correcly, I’d suggest adding a bit more excitement to the text, especially for the “New Filter Options” and “Show the Filters in the Buttons Bar of the Call Hierarchy View” sections.
Everything else looks good : )

@Bananeweizen
Copy link
Contributor Author

@jannisCode I must admit I have not been aware of those instructions over all the years. Still, I interpret that sentence as "don't write boring details", the excitement should come from the new functionality, not from the wording. :)
The previous version of the changelog reminded me far too much of a slimy insurance agent trying to sell me something, and I react rather negatively to such language.

Feel free to rework my change to add more excitement. I can't really do that, I'm based on facts.

Copy link
Member

@fedejeanne fedejeanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Bananeweizen I'm actually more with Jannis on this one. I am also more driven by facts than excitement but I do like to try new things and let new contributors bring "their own thing to the mix".

In some cases, I'd rather leave the text as it was before (i.e. revert the changes proposed in this PR). I like the changes proposed for the new functionalities of Platform though.

@fedejeanne fedejeanne merged commit 203d7e6 into eclipse-platform:master Nov 18, 2024
1 check passed
@fedejeanne
Copy link
Member

@Bananeweizen I took the liberty to undo 2 of your changes and merging this PR, only because I need it merged in order to proceed with #241.

The N&Ns should be ready by EOD today.

Sorry for hijacking your PR.

@Bananeweizen Bananeweizen deleted the image_paths branch November 19, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants